Skip to content

feat: append additional configuration to deadline-worker systemd config during linux worker setup #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

godobyte
Copy link
Contributor

What was the problem/requirement? (What/Why)

Worker configuration in test fixture overwrites existing deadline-worker.service.d/config.conf, this cleans up the existing configuration prior to running this setup.

What was the solution? (How)

Append additional configuration rather than overwriting the existing configuration.

What is the impact of this change?

Allow deadline-worker.service.d/config.conf creation elsewhere and only expend additional config at end of file

How was this change tested?

Running through the following commands

~> rm -r -f /tmp/systemd/system/deadline-worker.service.d/
~> mkdir -p /tmp/systemd/system/deadline-worker.service.d/
~> mkdir -p /tmp/systemd/system/deadline-worker.service.d/
~> echo "[Service]" >> /tmp/systemd/system/deadline-worker.service.d/config
~> cat /tmp/systemd/system/deadline-worker.service.d/config
[Service]
~> echo "Environment=AWS_REGION=us-west-2" >> /tmp/systemd/system/deadline-worker.service.d/config
~> cat /tmp/systemd/system/deadline-worker.service.d/config
[Service]
Environment=AWS_REGION=us-west-2
~> echo "[Service]" >> /tmp/systemd/system/deadline-worker.service.d/config
~> cat /tmp/systemd/system/deadline-worker.service.d/config
[Service]
Environment=AWS_REGION=us-west-2
[Service]
~> echo "Environment=STAGE=alpha" >> /tmp/systemd/system/deadline-worker.service.d/config
~> cat /tmp/systemd/system/deadline-worker.service.d/config
[Service]
Environment=AWS_REGION=us-west-2
[Service]
Environment=STAGE=alpha

Was this change documented?

N/A

Is this a breaking change?

No


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@godobyte godobyte marked this pull request as ready for review March 31, 2025 22:23
@godobyte godobyte requested a review from a team as a code owner March 31, 2025 22:23
@godobyte godobyte changed the title feat: allow deadline-worker.service.d/config.conf creation elsewhere feat: append additional configuration to deadline-worker systemd config during linux worker setup Mar 31, 2025
@godobyte godobyte merged commit 13d60e1 into aws-deadline:mainline Mar 31, 2025
16 checks passed
@godobyte godobyte deleted the serviced branch March 31, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants