test: Separating class fixtures to allow for more test configuration #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Church Hindley <[email protected]>
|
leongdl
reviewed
Apr 1, 2025
|
Found a better way to do this without modifying the existing test fixtures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The existing framework deployed and installed the worker agent automatically and I am trying to test different configurations at install.
What was the solution? (How)
By separating some of the fixture configurations, we can setup our instance and worker agent as needed for the test.
What is the impact of this change?
These changes should have no impact on existing tests. Just provides more control over our specific end-to-end tests when needed.
How was this change tested?
Tested these fixtures changes locally, against individual tests and the windows/linux e2e tests
Was this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.