-
Notifications
You must be signed in to change notification settings - Fork 2
[SCRUM-622] refactor(auth): use Powertools secret retrieval for tokens from secrets manager #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sh1un
wants to merge
2
commits into
dev
Choose a base branch
from
feature/SCRUM-622-refactor-secrets-manager-code-replaced-by-powertools
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| aws-lambda-powertools==3.30.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| pyjwt==2.8.0 | ||
| aws-lambda-powertools==3.30.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,13 @@ | ||
| import os | ||
|
|
||
| import boto3 | ||
| import jwt | ||
| from aws_lambda_powertools.utilities.parameters import get_secret | ||
|
|
||
|
|
||
| class AuthenticationError(Exception): | ||
| pass | ||
|
|
||
|
|
||
| _secretsmanager_client = boto3.client("secretsmanager") | ||
| _jwt_secret_cache = None | ||
|
|
||
|
|
||
| def _extract_token(headers): | ||
| if not headers: | ||
| raise AuthenticationError("Missing Authorization header") | ||
|
|
@@ -44,19 +40,12 @@ def decode_rsvp_token(headers): | |
|
|
||
|
|
||
| def _get_jwt_secret(): | ||
| global _jwt_secret_cache | ||
|
|
||
| if _jwt_secret_cache is not None: | ||
| return _jwt_secret_cache | ||
|
|
||
| jwt_secret_arn = os.getenv("JWT_SECRET_ARN") | ||
| if not jwt_secret_arn: | ||
| raise RuntimeError("JWT_SECRET_ARN environment variable is not set") | ||
|
|
||
| response = _secretsmanager_client.get_secret_value(SecretId=jwt_secret_arn) | ||
| secret_string = response.get("SecretString") | ||
| if not secret_string: | ||
| secret = get_secret(jwt_secret_arn) | ||
| if not secret: | ||
| raise RuntimeError("JWT secret is empty") | ||
|
|
||
| _jwt_secret_cache = secret_string | ||
| return _jwt_secret_cache | ||
| return secret | ||
|
Comment on lines
46
to
+60
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here: Worth adding a logger for get_secret to get more info when there is an error: sth like this: |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| pyjwt==2.8.0 | ||
| aws-lambda-powertools==3.30.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| requests | ||
| pycryptodome | ||
| aws-lambda-powertools==3.30.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth adding a logger for get_secret to get more info when there is an error:
sth like this: