Refactor dependency resolution out of deployment handler #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -107,12 +110,13 @@ GglError get_root_ca_path(char **root_ca_path) { | |||
| return ret; | |||
| } | |||
|
|
|||
| *root_ca_path = (char *) resp.data; | |||
| memcpy(root_ca_path->data, resp.data, resp.len); | |||
There was a problem hiding this comment.
We need to verify that the buffer is at least as long as resp.data before copying over the data. Similarly in other places
| @@ -93,6 +94,7 @@ GglError get_thing_name(GglBuffer *thing_name) { | |||
| return ret; | |||
| } | |||
|
|
|||
| assert(thing_name->len <= resp.len); | |||
There was a problem hiding this comment.
I think that this assert is wrong. Should it not be thing_name->len > resp.len?
we should also fail gracefully in case the lengths do no match.
I think it can be done as such:
if(thing_name->len <= resp.len) {
assert(false);
return GGL_ERR_FAILURE;
}This would allow us to fail gracefully even when the assert is not defined in production environments.
| @@ -110,6 +112,7 @@ GglError get_root_ca_path(GglBuffer *root_ca_path) { | |||
| return ret; | |||
| } | |||
|
|
|||
| assert(root_ca_path->len <= resp.len); | |||
There was a problem hiding this comment.
This assert also seems wrong no?
sameerzuberi
force-pushed
the
refactor-deployments
branch
from
452e90d to
2b32a7e
Compare
patrzhan
approved these changes
Nov 22, 2024
|
PR #762 covers it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.