Remove undesirable usage of static #802
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archigup
reviewed
Jan 28, 2025
| [16384] // TODO: Clean up usages of static variables in this | ||
| // file, many may be more appropriately non-static to | ||
| // prevent issues where the memory is not re-initalized | ||
| // to zero when the function is re-called |
There was a problem hiding this comment.
If memory needs to be zeroed should be memset.
Though this might be fine as non-static, yeah.
aws-kevinrickard
force-pushed
the
static-cleanup
branch
from
983491d to
426ac67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fixes an issue where the buffer is reused on subsequent calls without being re-initialized to zero, causing messages from a previous call to show up in newer call logs.
Not needed for the 2.0.1 release, but can optionally be included.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.