Add support for http retry on failure #825
Open
+174
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawalexe
force-pushed
the
retry
branch
2 times, most recently
from
524e43a to
8b676b3
Compare
cookpate
force-pushed
the
retry
branch
4 times, most recently
from
5133234 to
529ef7a
Compare
archigup
reviewed
Apr 3, 2025
archigup
reviewed
Apr 3, 2025
archigup
reviewed
Apr 3, 2025
| case 400: // Generic client error | ||
| case 408: // Request timeout | ||
| // TODO: 429 can contain a retry-after header. | ||
| // This should be used as the backoff. |
There was a problem hiding this comment.
if retry-after is like 2 days, we dont want to block that long. Probably would need to cap the accepted value.
archigup
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.