Skip to content

fix: properly guard lifecycle result callbacks by generation #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: properly guard lifecycle result callbacks by generation #1752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/com/aws/greengrass/lifecyclemanager/GenericExternalService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,8 +383,8 @@ protected void startup() throws InterruptedException {
logger.atInfo().kv(EXIT_CODE, exit).log("Startup script exited");
separateLogger.atInfo().kv(EXIT_CODE, exit).log("Startup script exited");
State state = getState();
if (startingStateGeneration == getStateGeneration() && State.STARTING.equals(state)
|| State.RUNNING.equals(state)) {
if (startingStateGeneration == getStateGeneration()
&& (State.STARTING.equals(state) || State.RUNNING.equals(state))) {
if (exit == 0 && State.STARTING.equals(state)) {
reportState(State.RUNNING);
} else if (exit != 0) {
Expand Down Expand Up @@ -543,7 +543,7 @@ private void handleRunScript() throws InterruptedException {
if (timeout != null) {
Exec processToClose = runResult.getExec();
context.get(ScheduledExecutorService.class).schedule(() -> {
if (processToClose.isRunning()) {
if (processToClose.isRunning()) { // TODO: Should we have a generation check here as well?
try {
logger.atWarn("service-run-timed-out")
.log("Service failed to run within timeout, calling close in process");
Expand Down
Loading