Skip to content

Conversation

@JaseKoonce
Copy link
Contributor

@JaseKoonce JaseKoonce commented Jul 7, 2025

What does this PR do?

Currently there are no filters for what ASGs events to monitor for NTH purposes. This can cause every eventbridge rule in your account to review events from every single ASG in your account. This PR wont change the default behavior (recieve all events), but allows you to pass in the ASG names you want to receive events from.

Motivation

  • Seeing errors on our NTH pods about nodes and ASGs it never should have seen events from.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

plan output:
image

@JaseKoonce JaseKoonce requested a review from a team as a code owner July 7, 2025 13:48
@JaseKoonce JaseKoonce closed this Jul 7, 2025
@JaseKoonce JaseKoonce changed the title Feat/configurable event pattern feat: configurable event pattern Jul 7, 2025
@JaseKoonce JaseKoonce reopened this Jul 7, 2025
@JaseKoonce JaseKoonce changed the title feat: configurable event pattern feat: Configurable event patterns for NTH EventBridge rules Jul 7, 2025
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the enhancement!

@askulkarni2 askulkarni2 merged commit 909ff75 into aws-ia:main Jul 14, 2025
3 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants