-
Notifications
You must be signed in to change notification settings - Fork 59
Delete mwaa resource lifecycle block with ignore changes #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening the PR! We ran into this issue while upgrading MWAA and trying to update the requirements.txt file accordingly. @vara-bonthu is there anything blocking this change? |
Please resolve the conflicts so that we can merge the PR |
It would be nice to still have a option to ignore these values. In our workflow we upload files to S3 via CI/CD. We don't have it built yet but eventually we plan on automatically updating these values from our CI/CD pipeline. |
Since this are variables I would expect this somehow outside of this module. Problem remains, that once it is in this module, it is enforced for everyone. |
@vara-bonthu superseded by #60 |
#60 is merged. You. An close this PR now. Thanks |
What does this PR do?
This PR deletes lifecycle block from MWAA resource in order to update MWAA whenever requirements or plugins objects version changes.
Motivation
Motivation is to avoid restarting MWAA manually after update in requirements.txt or plugins.
More
pre-commit run -a
with this PRFor Moderators
Additional Notes