Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ADOT V1.x to latest otel versions (NOT READY). #955

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:

- uses: actions/setup-java@v4
with:
java-version: 17
java-version: 21
distribution: temurin

- name: Cache local Maven repository
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-java@v4
with:
java-version: 17
java-version: 21
distribution: 'temurin'
- uses: gradle/wrapper-validation-action@v1
- name: Configure AWS Credentials
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/e2e-tests-app-with-java-agent.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:

- uses: actions/setup-java@v4
with:
java-version: 17
java-version: 21
distribution: temurin

# cache local patch outputs
Expand Down Expand Up @@ -83,7 +83,7 @@ jobs:

- uses: actions/setup-java@v4
with:
java-version: 17
java-version: 21
distribution: 'temurin'
- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@v4
Expand Down Expand Up @@ -114,7 +114,7 @@ jobs:

- uses: actions/setup-java@v4
with:
java-version: 17
java-version: 21
distribution: 'temurin'
- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@v4
Expand Down Expand Up @@ -145,7 +145,7 @@ jobs:

- uses: actions/setup-java@v4
with:
java-version: 17
java-version: 21
distribution: 'temurin'
- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-tests-with-operator.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:

- uses: actions/setup-java@v4
with:
java-version: 17
java-version: 21
distribution: temurin

# cache local patch outputs
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/main-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
branches:
- main
- "release/v*"
- version-upgrade-v1
env:
AWS_DEFAULT_REGION: us-east-1
STAGING_ECR_REGISTRY: 611364707713.dkr.ecr.us-west-2.amazonaws.com
Expand All @@ -25,7 +26,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-java@v4
with:
java-version: 17
java-version: 21
distribution: temurin
# vaadin 14 tests fail with node 18
- name: Set up Node
Expand Down Expand Up @@ -59,7 +60,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-java@v4
with:
java-version: 17
java-version: 21
distribution: temurin

# cache local patch outputs
Expand Down Expand Up @@ -194,7 +195,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-java@v4
with:
java-version: 17
java-version: 21
distribution: 'temurin'
- uses: gradle/wrapper-validation-action@v1

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/nightly-upstream-snapshot-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:

- uses: actions/setup-java@v4
with:
java-version: 17
java-version: 21
distribution: 'temurin'

- uses: gradle/wrapper-validation-action@v1
Expand Down Expand Up @@ -120,7 +120,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-java@v4
with:
java-version: 17
java-version: 21
distribution: 'temurin'
- uses: gradle/wrapper-validation-action@v1

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/owasp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- name: Set up Java for dependency scan
uses: actions/setup-java@v4
with:
java-version: 17
java-version: 21
distribution: 'temurin'

- name: Configure AWS credentials for dependency scan
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/patch-release-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:

- uses: actions/setup-java@v4
with:
java-version: 17
java-version: 21
distribution: 'temurin'
- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@v4
Expand Down
66 changes: 33 additions & 33 deletions .github/workflows/pr-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,35 +8,35 @@ env:
TEST_TAG: public.ecr.aws/aws-observability/adot-autoinstrumentation-java:test

jobs:
testpatch:
name: Test patches applied to dependencies
runs-on: aws-otel-java-instrumentation_ubuntu-latest_32-core
steps:
- uses: actions/checkout@v4

- uses: actions/setup-java@v4
with:
java-version: 17
distribution: temurin
# vaadin 14 tests fail with node 18
- name: Set up Node
uses: actions/setup-node@v4
with:
node-version: 16

# vaadin tests use pnpm
- name: Cache pnpm modules
uses: actions/cache@v3
with:
path: ~/.pnpm-store
key: ${{ runner.os }}-test-cache-pnpm-modules

- uses: gradle/wrapper-validation-action@v1

- uses: ./.github/actions/patch-dependencies
with:
run_tests: "true"

# testpatch:
# name: Test patches applied to dependencies
# runs-on: aws-otel-java-instrumentation_ubuntu-latest_32-core
# steps:
# - uses: actions/checkout@v4
#
# - uses: actions/setup-java@v4
# with:
# java-version: 21
# distribution: temurin
# # vaadin 14 tests fail with node 18
# - name: Set up Node
# uses: actions/setup-node@v4
# with:
# node-version: 16
#
# # vaadin tests use pnpm
# - name: Cache pnpm modules
# uses: actions/cache@v3
# with:
# path: ~/.pnpm-store
# key: ${{ runner.os }}-test-cache-pnpm-modules
#
# - uses: gradle/wrapper-validation-action@v1
#
# - uses: ./.github/actions/patch-dependencies
# with:
# run_tests: "true"
#
build:
name: Build on ${{ matrix.os }}
runs-on: ${{ matrix.os }}
Expand All @@ -58,7 +58,7 @@ jobs:

- uses: actions/setup-java@v4
with:
java-version: 17
java-version: 21
distribution: temurin

- uses: gradle/wrapper-validation-action@v1
Expand All @@ -71,9 +71,9 @@ jobs:
~/.m2/repository/io/opentelemetry/
key: ${{ runner.os }}-maven-local-${{ hashFiles('.github/patches/opentelemetry-java*.patch') }}

- name: Publish patched dependencies to maven local
uses: ./.github/actions/patch-dependencies
if: ${{ matrix.os != 'windows-latest' }} # Skip patch on windows as it is not possible to build opentelemetry-java on windows
# - name: Publish patched dependencies to maven local
# uses: ./.github/actions/patch-dependencies
# if: ${{ matrix.os != 'windows-latest' }} # Skip patch on windows as it is not possible to build opentelemetry-java on windows

- name: Build with Gradle with Integration tests
uses: gradle/gradle-build-action@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-java@v4
with:
java-version: 17
java-version: 21
distribution: 'temurin'
- uses: gradle/wrapper-validation-action@v1

Expand Down
6 changes: 3 additions & 3 deletions appsignals-tests/contract-tests/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import org.jetbrains.kotlin.gradle.tasks.KotlinCompile

plugins {
java
kotlin("jvm") version "1.8.22"
kotlin("jvm") version "2.1.0-RC2"
}

java {
Expand Down Expand Up @@ -98,8 +98,8 @@ tasks {
dependsOn(":appsignals-tests:images:http-clients:spring-mvc-client:jibDockerBuild")
dependsOn(":appsignals-tests:images:http-clients:apache-http-client:jibDockerBuild")
dependsOn(":appsignals-tests:images:http-clients:netty-http-client:jibDockerBuild")
dependsOn(":appsignals-tests:images:aws-sdk:aws-sdk-v1:jibDockerBuild")
dependsOn(":appsignals-tests:images:aws-sdk:aws-sdk-v2:jibDockerBuild")
// dependsOn(":appsignals-tests:images:aws-sdk:aws-sdk-v1:jibDockerBuild")
// dependsOn(":appsignals-tests:images:aws-sdk:aws-sdk-v2:jibDockerBuild")
dependsOn(":appsignals-tests:images:grpc:grpc-client:jibDockerBuild")
dependsOn(":appsignals-tests:images:grpc:grpc-server:jibDockerBuild")
dependsOn(":appsignals-tests:images:jdbc:jibDockerBuild")
Expand Down
5 changes: 5 additions & 0 deletions appsignals-tests/images/grpc/grpc-base/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ plugins {
id("com.google.protobuf") version "0.9.4"
}

java {
sourceCompatibility = JavaVersion.VERSION_11
targetCompatibility = JavaVersion.VERSION_11
}

group = "software.amazon.opentelemetry"

dependencies {
Expand Down
4 changes: 2 additions & 2 deletions awsagentprovider/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ dependencies {
testRuntimeOnly("io.opentelemetry:opentelemetry-exporter-otlp-common")

compileOnly("com.google.code.findbugs:jsr305:3.0.2")
testImplementation("org.mockito:mockito-core:5.3.1")
testImplementation("org.mockito:mockito-junit-jupiter:5.8.0")
testImplementation("org.mockito:mockito-core:5.14.2")
testImplementation("org.mockito:mockito-junit-jupiter:5.14.2")
}

tasks {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,9 @@ private SpanData buildSpanDataMock() {
when(mockSpanData.getParentSpanContext()).thenReturn(parentSpanContextMock);

SpanContext spanContextMock = mock(SpanContext.class);
TraceFlags spanContextTraceFlagsMock = mock(TraceFlags.class);
when(spanContextMock.isValid()).thenReturn(true);
when(spanContextMock.getTraceFlags()).thenReturn(spanContextTraceFlagsMock);
when(mockSpanData.getSpanContext()).thenReturn(spanContextMock);

TraceState traceState = TraceState.builder().build();
Expand Down
8 changes: 5 additions & 3 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ import org.gradle.api.tasks.testing.logging.TestExceptionFormat
plugins {
java

kotlin("jvm") version "2.1.0-RC2"
// id("com.diffplug.spotless") version "6.25.0"
id("com.diffplug.spotless")
id("com.github.jk1.dependency-license-report")
id("io.github.gradle-nexus.publish-plugin")
Expand Down Expand Up @@ -68,7 +70,7 @@ allprojects {

spotless {
kotlinGradle {
ktlint("0.48.0").userData(mapOf("indent_size" to "2", "continuation_indent_size" to "2"))
ktlint("1.4.0").editorConfigOverride(mapOf("indent_size" to "2", "continuation_indent_size" to "2"))

// Doesn't support pluginManagement block
targetExclude("settings.gradle.kts")
Expand All @@ -81,8 +83,8 @@ allprojects {

plugins.withId("java") {
java {
sourceCompatibility = JavaVersion.VERSION_1_8
targetCompatibility = JavaVersion.VERSION_1_8
sourceCompatibility = JavaVersion.VERSION_21
targetCompatibility = JavaVersion.VERSION_21

withJavadocJar()
withSourcesJar()
Expand Down
29 changes: 15 additions & 14 deletions dependencyManagement/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,16 @@ plugins {

data class DependencySet(val group: String, val version: String, val modules: List<String>)

val TEST_SNAPSHOTS = rootProject.findProperty("testUpstreamSnapshots") == "true"
val testSnapshots = rootProject.findProperty("testUpstreamSnapshots") == "true"

// This is the version of the upstream instrumentation BOM
val otelVersion = "1.32.1-adot2"
val otelSnapshotVersion = "1.33.0"
val otelAlphaVersion = if (!TEST_SNAPSHOTS) "$otelVersion-alpha" else "$otelSnapshotVersion-alpha-SNAPSHOT"
val otelJavaAgentVersion = if (!TEST_SNAPSHOTS) otelVersion else "$otelSnapshotVersion-SNAPSHOT"
val otelVersion = "1.33.6"
val otelSnapshotVersion = "1.33.6"
val otelAlphaVersion = if (!testSnapshots) "$otelVersion-alpha" else "$otelSnapshotVersion-alpha-SNAPSHOT"
val otelJavaAgentVersion = if (!testSnapshots) otelVersion else "$otelSnapshotVersion-SNAPSHOT"
// All versions below are only used in testing and do not affect the released artifact.

val DEPENDENCY_BOMS = listOf(
val dependencyBoms = listOf(
"com.amazonaws:aws-java-sdk-bom:1.12.599",
"com.fasterxml.jackson:jackson-bom:2.16.0",
"com.google.guava:guava-bom:33.0.0-jre",
Expand All @@ -48,7 +48,7 @@ val DEPENDENCY_BOMS = listOf(
"software.amazon.awssdk:bom:2.21.33",
)

val DEPENDENCY_SETS = listOf(
val dependencySets = listOf(
DependencySet(
"org.assertj",
"3.24.2",
Expand All @@ -69,14 +69,15 @@ val DEPENDENCY_SETS = listOf(
),
)

val DEPENDENCIES = listOf(
val dependencyLists = listOf(
"commons-logging:commons-logging:1.2",
"com.sparkjava:spark-core:2.9.4",
"com.squareup.okhttp3:okhttp:4.12.0",
"io.opentelemetry.contrib:opentelemetry-aws-xray:1.32.0",
"io.opentelemetry.contrib:opentelemetry-aws-resources:1.32.0-alpha",
"io.opentelemetry.contrib:opentelemetry-aws-xray:1.39.0",
"io.opentelemetry.contrib:opentelemetry-aws-resources:1.39.0-alpha",
"io.opentelemetry.proto:opentelemetry-proto:1.0.0-alpha",
"io.opentelemetry.javaagent:opentelemetry-javaagent:$otelJavaAgentVersion",
"io.opentelemetry:opentelemetry-extension-aws:1.20.1",
"net.bytebuddy:byte-buddy:1.14.10",
)

Expand All @@ -85,17 +86,17 @@ javaPlatform {
}

dependencies {
for (bom in DEPENDENCY_BOMS) {
for (bom in dependencyBoms) {
api(platform(bom))
}
constraints {
for (set in DEPENDENCY_SETS) {
for (set in dependencySets) {
for (module in set.modules) {
api("${set.group}:$module:${set.version}")
}
}

for (dependency in DEPENDENCIES) {
for (dependency in dependencyLists) {
api(dependency)
}
}
Expand All @@ -104,7 +105,7 @@ dependencies {
rootProject.allprojects {
plugins.withId("com.github.jk1.dependency-license-report") {
configure<LicenseReportExtension> {
val bomExcludes = DEPENDENCY_BOMS.stream()
val bomExcludes = dependencyBoms.stream()
.map { it.substring(0, it.lastIndexOf(':')) }
.toArray { length -> arrayOfNulls<String>(length) }
excludes = bomExcludes
Expand Down
Binary file modified gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
Loading
Loading