Potential fix for code scanning alert no. 3: Workflow does not contain permissions#159
Merged
Potential fix for code scanning alert no. 3: Workflow does not contain permissions#159
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
ezhang6811
reviewed
Oct 14, 2025
|
|
||
| jobs: | ||
| stale-close: | ||
| permissions: |
There was a problem hiding this comment.
Do we need contents: write? See https://github.com/aws-observability/aws-otel-python/pull/99/files
also: not blocking, but for parity we could put all permissions at job level.
Contributor
Author
There was a problem hiding this comment.
contents: write # only for delete-branch option - https://github.com/actions/stale
Will remove.
ezhang6811
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/aws-observability/aws-otel-ruby/security/code-scanning/3
To remedy the issue, a
permissionsblock should be added to restrict the GITHUB_TOKEN privileges so the workflow or job only receives the rights it needs. Specifically, theactions/staleuses the bot to read and write issues and pull-requests, label them, and potentially close them. The minimal required set iscontents: write,issues: write, andpull-requests: write. This block can be placed either at the root of the workflow (making it apply to all jobs) or at the job level (stale-close). According to the CodeQL recommendation, it's preferable to put it at the job level so that only the job has the permissions it needs.Edit
.github/workflows/stale-bot.yml, and underjobs: stale-close:(beforeruns-on:), add:No new imports or external code definitions are required.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.