Add pattern validation to Instrumentation CRD config fields - #314
Merged
Conversation
sky333999
previously approved these changes
May 26, 2026
mitali-salvi
previously approved these changes
May 27, 2026
Copy all 4 CRDs from amazon-cloudwatch-agent-operator config/crd/bases/ (branch httpd-nginx-autoinst). Changes: - configPath/configFile: pattern ^[A-Za-z0-9._/-]*$ + maxLength 256 - x-kubernetes-list-type: atomic on all list fields - appArmorProfile added to securityContext - metricsConfig required enforcement for dcgmexporters - 21 new field defaults (protocol: TCP, etc.) Validated on live cluster test-perm (server-side apply + CR tests).
mitali-salvi
approved these changes
Jun 3, 2026
JayPolanco
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
bundled Instrumentation CRD allowed arbitrary character and length values for configPath and configFile, leaving validation entirely to the operator.
Description of changes:
Adds length and pattern constraints to
configPathandconfigFilein the bundled Instrumentation CRD to align with the upstream operator change.Test
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.