Enable OTel Container Insights in Windows EKS integ test harness - #343
Merged
Conversation
The windowslinux validation test expects OTel Container Insights resources (kube-state-metrics, node-exporter, cloudwatch-agent-cluster-scraper), but the Windows EKS Terraform harness never set otelContainerInsights.enabled (the Linux harness does). This caused TestResourcesGenerated to fail on service/deployment/ daemonset counts and the OTel CI RBAC checks. Enable the flag and wait for the newly-rendered workloads to roll out before validating.
movence
approved these changes
Jul 23, 2026
jefchien
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the failing EKS Win2019 / EKS Win2022 integration-test jobs.
Root cause
The shared
windowslinux-tagged validation test (validations/eks/resources_generated_test.go) expects the OTel Container Insights resources to be present:kube-state-metrics(Deployment, Service, ServiceAccount, ClusterRole, ClusterRoleBinding)node-exporter(DaemonSet, Service, ServiceAccount, Role, RoleBinding)cloudwatch-agent-cluster-scraper(operator-created Deployment +-monitoringService)All of these are gated in the chart behind
otelContainerInsights.enabled, which defaults tofalse. The Linux EKS harness (terraform/eks/main.tf) setsotelContainerInsights.enabled=true, so it passes. The Windows harness (terraform/eks/windows/main.tf) never set it, so those resources were absent andTestResourcesGeneratedfailed on:Should be truechecksChange
otelContainerInsights.enabled=truein the Windowshelm_release, matching the Linux harness.node-exporterDaemonSet,kube-state-metricsDeployment,cloudwatch-agent-cluster-scraperDeployment) before the validator runs.Verification
helm templatewith--set otelContainerInsights.enabled=true(vs default) renders exactly the missing objects, accounting 1:1 for every failing assertion (+3 services, +2 deployments, +1 daemonset, +6 RBAC objects). Single Windows dir is parameterized byvar.windows_os_version, so this covers both Win2019 and Win2022 jobs.