Upgrade AWS CPP SDK Version for WebRTC-C Canary#313
Open
stefankiesz wants to merge 4 commits intomasterfrom
Open
Upgrade AWS CPP SDK Version for WebRTC-C Canary#313stefankiesz wants to merge 4 commits intomasterfrom
stefankiesz wants to merge 4 commits intomasterfrom
Conversation
hassanctech
reviewed
Aug 28, 2023
disa6302
approved these changes
Jan 16, 2024
sirknightj
approved these changes
Jan 16, 2024
sirknightj
reviewed
Jan 16, 2024
| @@ -1,4 +1,4 @@ | |||
| cmake_minimum_required(VERSION 3.11) | |||
| cmake_minimum_required(VERSION 3.13) | |||
Contributor
There was a problem hiding this comment.
Thoughts on bumping this all the way to most recent?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Updates AWS CPP SDK version from 1.9.67 to 1.11.143 in WebRTC-C Canary.
CMAKE_PREFIX_PATHis now set, and it is set to the dependency build directory/build/_depsundefined reference to 'EVP_idea_cbc@OPENSSL_1_1_0'errors associated with the following warning by directly specifying which directory to search in for dependencies./build/_deps/libis then added tolink_directoriesto point to the dependency libraries, preventing the following errors:Testing
These changes have been tested by successfully running
cmake,make, and./kvsWebrtcCanaryWebrtcand then verifying that metrics are emitting to CloudWatch.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.