Skip to content

Upgrade AWS CPP SDK Version for WebRTC-C Canary#313

Open
stefankiesz wants to merge 4 commits intomasterfrom
canary-webrtc-upgrade-aws-sdk-version
Open

Upgrade AWS CPP SDK Version for WebRTC-C Canary#313
stefankiesz wants to merge 4 commits intomasterfrom
canary-webrtc-upgrade-aws-sdk-version

Conversation

@stefankiesz
Copy link
Copy Markdown
Contributor

Changes

Updates AWS CPP SDK version from 1.9.67 to 1.11.143 in WebRTC-C Canary.

  • CMAKE_PREFIX_PATH is now set, and it is set to the dependency build directory /build/_deps
    • This solved undefined reference to 'EVP_idea_cbc@OPENSSL_1_1_0' errors associated with the following warning by directly specifying which directory to search in for dependencies.
Cannot generate a safe runtime search path for target [...] because files in some directories
may conflict with libraries in implicit directories:
    runtime library [libcrypto.so.1.1] in /usr/lib/x86_64-linux-gnu may be hidden by files in:
      /home/ubuntu/amazon-kinesis-video-streams-demos/canary/webrtc-c/build/_deps/webrtc-src/open-source/lib
Some of these libraries may not be found correctly.  
  • /build/_deps/lib is then added to link_directories to point to the dependency libraries, preventing the following errors:
/usr/bin/ld: cannot find -lkvspicUtils
/usr/bin/ld: cannot find -lkvsCommonLws
/usr/bin/ld: cannot find -lwebsockets

Testing

These changes have been tested by successfully running cmake, make, and ./kvsWebrtcCanaryWebrtc and then verifying that metrics are emitting to CloudWatch.



By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Comment thread canary/webrtc-c/CMakeLists.txt Outdated
@stefankiesz stefankiesz requested a review from disa6302 September 1, 2023 19:40
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.11)
cmake_minimum_required(VERSION 3.13)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on bumping this all the way to most recent?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants