Add sample app to stream with WebRTC and Stream Producer SDK simultaneously#414
Open
miratono wants to merge 8 commits intoaws-samples:masterfrom
Open
Add sample app to stream with WebRTC and Stream Producer SDK simultaneously#414miratono wants to merge 8 commits intoaws-samples:masterfrom
miratono wants to merge 8 commits intoaws-samples:masterfrom
Conversation
added 5 commits
September 12, 2025 17:44
sirknightj
reviewed
Sep 16, 2025
Author
|
@sirknightj Hi thanks for the review. Just fixed the codes according to your review so please kindly check it. |
sirknightj
reviewed
Nov 10, 2025
Contributor
sirknightj
left a comment
sirknightj
left a comment
There was a problem hiding this comment.
Hi @miratono, thank you for your patience.
I was able to try it out, but ran into some issues. Wondering if you could take a look please?
| cd amazon-kinesis-video-streams-producer-sdk-cpp | ||
| mkdir -p build | ||
| cd build | ||
| cmake .. -DBUILD_DEPENDENCIES=OFF |
Contributor
There was a problem hiding this comment.
Also need -DBUILB_GSTREAMER_PLUGIN=ON
|
|
||
| 2. Configure GStreamer plugin path with the path where you build the KVS Streams Producer app, e.g., `export GST_PLUGIN_PATH=/home/pi/amazon-kinesis-video-streams-producer-sdk-cpp/build` | ||
|
|
||
| 3. Go to `amazon-kinesis-video-streams-webrtc-sdk-c/build/` and run `./samples/kvsWebRTCAndDirectStream <signaling channel name> <kvs stream name>` |
Contributor
There was a problem hiding this comment.
When I ran the make -j in the WebRTC-C build, I didn't see this file. This might require a modification to the CMakeLists to the samples directory to add the new executable.
And it might need some linking to the GStreamer libraries since I am seeing these build issues:
- "undefined reference to
g_main_loop_quit" - "undefined reference to
g_printerr" - "undefined reference to
gst_element_factory_make"
| @@ -0,0 +1,3 @@ | |||
| [submodule "amazon-kinesis-video-streams-producer-sdk-cpp"] | |||
Contributor
There was a problem hiding this comment.
Seems there are 2 .gitmodules files?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Added a gstreamer app sample (amazon-kinesis-video-streams-webrtc-sdk-c/samples/kvsWebRTCAndDirectStream.c) inside KVS WebRTC SDK to support streaming video to KVS with WebRTC SDK (for real-time use) and Stream Producer SDK (for near-realtime video ingestion), simultaneously from 1 camera source.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.