Update pgJDBC example to include non-admin and connection refresh logic#112
Merged
Update pgJDBC example to include non-admin and connection refresh logic#112
Conversation
wcmjunior
force-pushed
the
chore/update-pgjdbc-samples
branch
from
99b42b3 to
782cae8
Compare
Collaborator
trstephen-amazon
left a comment
trstephen-amazon
left a comment
There was a problem hiding this comment.
Add token refresh logic
Can you point this out for me?
| working-directory: ./java/pgjdbc | ||
| env: | ||
| CLUSTER_ENDPOINT: ${{ secrets.JAVA_PGJDBC_CLUSTER_ENDPOINT }} | ||
| CLUSTER_USER: admin |
Collaborator
There was a problem hiding this comment.
not blocking, see also
Comment on lines
+26
to
+114
| SPDX-License-Identifier: MIT-0 | ||
| SPDX-License-Identifier: Apache-2.0 |
Collaborator
There was a problem hiding this comment.
see also
Comment on lines
-33
to
+35
| <version>2.29.27</version> | ||
| <version>${aws.sdk.version}</version> |
Contributor
Author
Sorry, copy and paste issue. There is no token refresh logic as new tokens are created on every connection. :) |
trstephen-amazon
approved these changes
May 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the pgJDBC example. It includes the following changes:
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT-0 license.