Skip to content

DSQL Lambda - HowTo#118

Closed
imforster wants to merge 8 commits intomainfrom
dsql-lambda
Closed

DSQL Lambda - HowTo#118
imforster wants to merge 8 commits intomainfrom
dsql-lambda

Conversation

@imforster
Copy link
Copy Markdown
Contributor

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT-0 license.

Thank you for your contribution!

Copy link
Copy Markdown
Contributor

@wcmjunior wcmjunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor style and punctuation issues.

Comment thread lambda/README.md Outdated
Comment thread lambda/README.md Outdated
Comment thread lambda/README.md Outdated
Comment thread lambda/README.md Outdated
Comment thread lambda/README.md Outdated
Comment thread lambda/README.md Outdated
Copy link
Copy Markdown
Collaborator

@trstephen-amazon trstephen-amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Responded offline: I'm not sure having a console-driven workflow in GitHub provides value. A CDK-based example would be nice. It also duplicates public documentation and we'd need to keep both in sync somehow.

Comment thread lambda/index.mjs
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be index.js?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure original example had it this way.

Comment thread lambda/README.md
}
```

3. The folder also contains the following file `index.mjs` in this directory with the following content
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index.js?

imforster and others added 6 commits May 6, 2025 10:56
Co-authored-by: Wilson de Carvalho <796900+wcmjunior@users.noreply.github.com>
Co-authored-by: Wilson de Carvalho <796900+wcmjunior@users.noreply.github.com>
Co-authored-by: Wilson de Carvalho <796900+wcmjunior@users.noreply.github.com>
Co-authored-by: Wilson de Carvalho <796900+wcmjunior@users.noreply.github.com>
Co-authored-by: Wilson de Carvalho <796900+wcmjunior@users.noreply.github.com>
Co-authored-by: Wilson de Carvalho <796900+wcmjunior@users.noreply.github.com>
@imforster imforster closed this May 16, 2025
@imforster imforster deleted the dsql-lambda branch May 16, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants