Conversation
imforster
reviewed
May 9, 2025
| env: | ||
| CLUSTER_ENDPOINT: ${{ secrets.CPP_LIBPQ_CLUSTER_ENDPOINT }} | ||
| REGION: ${{ secrets.CPP_LIBPQ_CLUSTER_REGION }} | ||
| CLUSTER_USER: admin |
Contributor
There was a problem hiding this comment.
Can we also do a second pass that runs with non-admin user also?
Contributor
Author
There was a problem hiding this comment.
We currently don't do that for other languages. This could be next week addition.
This would not change code examples.
Contributor
There was a problem hiding this comment.
Let's create Taskei to ensure we don't forget this.
Contributor
Author
There was a problem hiding this comment.
We'll create a taskei ticket to track this for all languages.
imforster
approved these changes
May 9, 2025
danielfrankcom
pushed a commit
to marcbowes/aurora-dsql-samples
that referenced
this pull request
May 9, 2025
…-samples#123) * Installed dsql-signer from npm. Cleaned-up example and test code * Throwing error on fail * Made token const --------- Co-authored-by: Marcos Lopez <lmarcosi@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the cpp libpq example
Description of changes:
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT-0 license.