java: refactor SR cluster management#128
Conversation
- Deletes MR examples; this will be added back once SDKs are available with updated APIs - Combines all SR actions into a single test case. This'll let CI run faster because we don't have to create a cluster for each operation. - Adds a sweeper that deletes leaked clusters. Only runs in CI. - Remove unused and duplicate dependencies. - Readme corresponds to this code instead of pgJDBC ;)
whoopsie!
|
bah, mis-clicked the 'ready for review' button. It's probably ready but I want to see CI go green. edit: CI passed! |
| public class CreateCluster { | ||
|
|
||
| public static void main(String[] args) throws Exception { | ||
| public static void main(String[] args) { |
There was a problem hiding this comment.
nit: style should we have main at bottom instead?
There was a problem hiding this comment.
As is it reads imperatively: marshal input params -> set up client -> invoke. Other languages may have stricter requirements about the order of declared methods (i.e. no use before declare) but I'm biasing for readability.
| * <li>Tagged with 'Name=java *'</li> | ||
| * </ol> | ||
| */ | ||
| static void deleteTestsClusters(DsqlClient client) { |
There was a problem hiding this comment.
When we worked on HowTos in past we discovered that the github can interrupt so this should help resolve orphan clusters (Only caveat is if we have already reached our cluster limit we will get an ugly error first).
|
Offline: got OK to merge from @imforster and @danielfrankcom |
4 participants
Changes
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT-0 license.
Thank you for your contribution!