go: refactor multi-region for new dsql sdk#129
Merged
Conversation
…g_setup state before delete
…g_setup state before delete
Contributor
|
Are there missing |
imforster
commented
May 15, 2025
imforster
commented
May 15, 2025
imforster
commented
May 15, 2025
imforster
commented
May 15, 2025
imforster
commented
May 15, 2025
imforster
commented
May 15, 2025
imforster
commented
May 15, 2025
* Update to dump variables * Fix format in yaml * Update format issue * Add Run info * Update test to use a unique id and also uses Repo tag. * Update environments * Updated unique_id to use run number. * Fix quote * Change to use Run ID as it is unique for each workflow run. * Also ensure that tags are created for repo. * Update delete multi region logic for tag filtering. * Move print to make it clear which cluster was located * Remove comments in TestMain * Improve error handling * Fix nil check. * Remove find_cluster_test was used in development but is not needed anymore. * Update to add environment variables * Fixed Makefile * Remove find_cluster_test was used in development but is not needed anymore. * Update to add environment variables * Fix typo in environment for cluster_id_2
imforster
force-pushed
the
create-multi-region
branch
from
d8bc36e to
fa9c739
Compare
…tice like other examples.
imforster
commented
May 16, 2025
danielfrankcom
approved these changes
May 16, 2025
Contributor
danielfrankcom
left a comment
danielfrankcom
left a comment
There was a problem hiding this comment.
Latest change set looks good, thanks for making those updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT-0 license.
Thank you for your contribution!