TypeORM - Updated sample to support non_admin_user#130
Merged
Conversation
vic-tsang
changed the title
added 2 commits
May 14, 2025 15:01
vic-tsang
force-pushed
the
typescript/typeorm
branch
from
29bad38 to
1932a09
Compare
added 2 commits
May 15, 2025 10:23
imforster
approved these changes
May 15, 2025
Contributor
imforster
left a comment
imforster
left a comment
There was a problem hiding this comment.
Worked with Victor and validated admin and non-admin. Readme updated to improve clarity. LGTM.
wcmjunior
reviewed
May 15, 2025
vic-tsang
force-pushed
the
typescript/typeorm
branch
from
2d55eba to
88729b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates:
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT-0 license.
Thank you for your contribution!