Skip to content

rust: update cluster management examples to use new API#137

Merged
danielfrankcom merged 1 commit into
mainfrom
chore/update-rust-cluster-management
May 16, 2025
Merged

rust: update cluster management examples to use new API#137
danielfrankcom merged 1 commit into
mainfrom
chore/update-rust-cluster-management

Conversation

@danielfrankcom
Copy link
Copy Markdown
Contributor

This change updates the Rust cluster management examples as follows:

  • Use new AWS SDK for multi-region management
  • Standardize examples based on AWS docs
  • Clean up documentation
  • Separate standalone binaries from tests
  • Add formatting check to workflow
  • Add binary execution check to workflow

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT-0 license.

Copy link
Copy Markdown
Collaborator

@trstephen-amazon trstephen-amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blockers. Left some optional points you can address at your discretion, or merge.

Comment thread .github/workflows/rust-cm-integ-tests.yml
Comment thread .github/workflows/rust-cm-integ-tests.yml
Comment thread .github/workflows/rust-cm-integ-tests.yml Outdated
Comment thread rust/cluster_management/src/bin/create_multi_region_clusters.rs Outdated
Comment thread rust/cluster_management/src/bin/create_single_region_cluster.rs Outdated
Comment thread rust/cluster_management/src/bin/create_single_region_cluster.rs Outdated
@danielfrankcom danielfrankcom force-pushed the chore/update-rust-cluster-management branch 2 times, most recently from f4af901 to 1f86c9a Compare May 15, 2025 17:58
@danielfrankcom
Copy link
Copy Markdown
Contributor Author

  • f4af901 addresses most active comments.
  • 1f86c9a updates the CI job to check all standalone binaries, and increases the job timeout for the test run from 15 mins to 30 due to a recent failure.

@danielfrankcom danielfrankcom force-pushed the chore/update-rust-cluster-management branch from 1f86c9a to 49e66f6 Compare May 15, 2025 18:00
@danielfrankcom
Copy link
Copy Markdown
Contributor Author

  • 49e66f6 makes the binary check job more permissive about the env var which is checked for

@danielfrankcom danielfrankcom force-pushed the chore/update-rust-cluster-management branch from 49e66f6 to ffc9d37 Compare May 15, 2025 18:03
@danielfrankcom
Copy link
Copy Markdown
Contributor Author

  • ffc9d37 updates the wording of the messages during the binary check

Copy link
Copy Markdown
Collaborator

@trstephen-amazon trstephen-amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this as-is. Still not convinced of the binary poking in CI but it's very unlikely to be a burden.

Comment thread .github/workflows/rust-cm-integ-tests.yml
Comment thread .github/workflows/rust-cm-integ-tests.yml Outdated
Comment thread rust/cluster_management/src/bin/create_single_region_cluster.rs Outdated
Comment thread rust/cluster_management/tests/multi_region_test.rs Outdated
Comment thread rust/cluster_management/tests/multi_region_test.rs Outdated
Comment thread rust/cluster_management/tests/multi_region_test.rs Outdated
@danielfrankcom danielfrankcom force-pushed the chore/update-rust-cluster-management branch from ffc9d37 to 1bda4e2 Compare May 16, 2025 16:31
@danielfrankcom danielfrankcom merged commit efa4597 into main May 16, 2025
4 checks passed
@danielfrankcom danielfrankcom deleted the chore/update-rust-cluster-management branch May 20, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants