Align all env variables for cluster management in all languages#147
Merged
Align all env variables for cluster management in all languages#147
Conversation
danielfrankcom
requested changes
May 17, 2025
Contributor
danielfrankcom
left a comment
There was a problem hiding this comment.
Changes here mostly look good.
I did a quick search in the branch and found the following which I think were missed:
go/cluster_management/cmd/update_cluster/update_cluster_integ_test.go
region: os.Getenv("REGION"),
identifier: os.Getenv("CLUSTER_ID"),
go/cluster_management/cmd/get_cluster/get_cluster_integ_test.go
region: os.Getenv("REGION"),
identifier: os.Getenv("CLUSTER_ID"),
For whatever reason it seems these are also setting environment variables but any change to that is likely out of scope. We should use consistent names imo. For extra weirdness points, the create_multi_region_integ_test.go file and the single-region equivalent don't use environment variables at all. Even the ones I mentioned above inconsistently reference the region, sometimes with an env var and sometimes hardcoded.
danielfrankcom
approved these changes
May 20, 2025
danielfrankcom
approved these changes
May 20, 2025
mitchell-elholm
requested changes
May 20, 2025
added 6 commits
May 20, 2025 13:55
aa72b5b to
c0aebf7
Compare
mitchell-elholm
approved these changes
May 20, 2025
danielfrankcom
approved these changes
May 20, 2025
Co-authored-by: Daniel Frankcom <frankcom@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Single Cluster
Multi Clusters
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT-0 license.
Thank you for your contribution!