python: Use direct TLS connections for SQLAlchemy#168
Merged
danielfrankcom merged 1 commit intomainfrom May 30, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the
SQLAlchemysample to setsslnegotiation=directas per #150.It does this conditionally based on the underlying
libpqversion, since the samepsycopg2version can be used with multiple versions oflibpq. I verified in the release notes here thatsslnegotiationhas been available since the17.0release and was not added as a minor version bump.As with #167, at the time of writing, the
psycopg2-binarypackage includeslibpq16.0, which doesn't support thesslnegotiationparameter. See the other PR for more detail, as the same applies here given SQLAlchemy's use ofpsycopg2in this sample.I added a section to the
README.mdfile which describes more about the TLS configuration, and calls out that direct TLS connections are a new feature and may not be supported by all driver versions. This section was already reviewed in #160, and will be added to all samples which support direct TLS connections.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT-0 license.