Use package-lock.json and npm ci for predictable dependencies#194
Merged
danielfrankcom merged 2 commits intomainfrom Oct 3, 2025
Merged
Use package-lock.json and npm ci for predictable dependencies#194danielfrankcom merged 2 commits intomainfrom
danielfrankcom merged 2 commits intomainfrom
Conversation
Contributor
|
my question is what happens if we need to update the packages we need to update the package-lock.json ? |
Contributor
Author
Yes, this is a standard part of the Node.js ecosystem. Previously we did not actually control the versions used for some of these samples, we just used a version based on the suggested range from the This change will let us make sure we are using the same version everywhere to prevent "works on my machine" issues. |
vic-tsang
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures the dependencies described by the Node.js packages in the repo will use the same dependencies across all developer machines, including the workflows.
The change adds
package-lock.jsonfiles where they were previously missing, and swaps the workflow files to usenpm cito avoid dependency versions being changed on the fly. In at least one case thenpm cifailed when testing locally since thepackage.jsonandpackage-lock.jsonfiles were out of sync which should never happen onmain.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT-0 license.