Add instruction for AWS Codecommit integration#3
Open
pmadc wants to merge 2 commits intoaws-samples:mainfrom
Open
Add instruction for AWS Codecommit integration#3pmadc wants to merge 2 commits intoaws-samples:mainfrom
pmadc wants to merge 2 commits intoaws-samples:mainfrom
Conversation
andskli
requested changes
Dec 21, 2021
Contributor
andskli
left a comment
andskli
left a comment
There was a problem hiding this comment.
thanks for the contribution, I do think that this could be simplified a bit, let me explain; right now there's quite some duplicated content being added to README.md, perhaps the CodeCommit specific things could be moved into a separate markdown file and linked from section 2 in the existing README.md instead?
I would also encourage you to use git remotes in your instructions instead of copying the content of the repository.
Contributor
|
It would be useful to have CodeCommit example, as using this text I was able to spot that I miss |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add instruction for AWS Codecommit integration
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.