-
Notifications
You must be signed in to change notification settings - Fork 309
ADD VPC Endpoint Support & Model Whitelisting #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
weisser-dev
wants to merge
15
commits into
aws-samples:main
Choose a base branch
from
HUK-COBURG:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+276
−10
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
3ca6f16
Add configurable Bedrock endpoint URLs via env vars
weisser-dev d578baf
Merge pull request #1 from HUK-COBURG/codex/add-vic-endpoint-support
weisser-dev 9fec98b
Add model whitelist configuration for Bedrock model exposure
weisser-dev 5e5fc72
Merge pull request #2 from HUK-COBURG/codex/create-model-whitelist-co…
weisser-dev a607cc7
Fix Bedrock endpoint env defaults and cache whitelist loading
weisser-dev 13eab9e
Merge pull request #3 from HUK-COBURG/codex/fix-service-crash-due-to-…
weisser-dev 80c068a
Fix Sonnet 4.5/4.6 Bedrock validation errors
weisser-dev 3929f94
Merge pull request #4 from HUK-COBURG/codex/investigate-error-400-in-…
weisser-dev fcf14b6
Harden whitelist loading and parameterize Bedrock endpoint URLs
weisser-dev bfa7203
Merge pull request #5 from HUK-COBURG/codex/address-critical-and-impo…
weisser-dev 82b4fc7
Fix Bedrock Qwen stopSequences ValidationException
weisser-dev e476d05
Merge pull request #6 from HUK-COBURG/codex/fix-bedrock-validation-er…
weisser-dev b5a73b5
Merge pull request #7 from aws-samples/main
weisser-dev 0f1716e
Harden Bedrock request validation and model compatibility
weisser-dev 02f317f
Merge pull request #8 from HUK-COBURG/codex/fix-bedrock-validation-er…
weisser-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor:
${BEDROCK_URL:-}sets an empty string when unset, not unset.This works today because
_env_or_none()insetting.pyconverts""toNone. But it's a subtle coupling — if_env_or_nonewere ever changed, the docker-compose default would break.Consider using
${BEDROCK_URL-}(without:) so the env var remains unset inside the container when not defined on the host, rather than being set to an empty string. This removes the dependency on_env_or_none()for correctness.