Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream websocket lambda #740

Open
wants to merge 2 commits into
base: v2
Choose a base branch
from

Conversation

mohanraj-u
Copy link

Issue #, if available:
#738
#738 (comment)

Description of changes:
-- Added support for local websocket deployment using FASTAPI
-- Refactored existing websocket implementation (see attached document)
Websocket Refactoring.pdf
-- Consistency for all Websocket messages to be JSON format

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mohanraj-u
Copy link
Author

-- Any additional changes needed to complete this PR?

@statefb
Copy link
Contributor

statefb commented Feb 28, 2025

@mohanraj-u Thank you for your contribution and implementing this feature request! I appreciate the work you've put into supporting local WebSocket development and debugging.

At the moment, our team is occupied with other priority tasks, so we may not be able to review this PR immediately. While local WebSocket development support would be valuable, it's not currently at the top of our priority list.

That said, we do recognize the importance of improving the development experience, especially for WebSocket functionality. We'll try to review this when our current workload permits.

As mentioned in our contribution guidelines, for substantial feature enhancements like this, we recommend discussing implementation approaches and details in the issue thread before proceeding with development work. This helps ensure smoother review and integration of PRs.

But, thanks again for your understanding and contribution to improving the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants