update: kubectl get command to use endpointslices#1866
Open
JuanitoFatas wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for eks-workshop ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
to remove warning of kubectl get endpoints -n ui ui Warning: v1 Endpoints is deprecated in v1.33+; use discovery.k8s.io/v1 EndpointSlice
JuanitoFatas
force-pushed
the
use-endpointslices
branch
from
d735594 to
89e35f0
Compare
Collaborator
|
Thanks for this submission, this is a good change, but we need to adjust the explanation around it, not just the command. If you're willing you can take a go at it and add to this PR, otherwise we will get to this soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spotted while at https://snapshots.eksworkshop.com/4f160659/docs/introduction/basics/services/#:~:text=Watch%20how%20the%20service%20endpoints%20update%3A
What this PR does / why we need it:
Use
kubectl get endpointslices -n uito remove warning from
Which issue(s) this PR fixes:
Fixes N/A
Quality checks
make test module="<module>"it was successful (see https://github.com/aws-samples/eks-workshop-v2/blob/main/docs/automated_tests.md)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.