generated from amazon-archives/__template_MIT-0
-
Notifications
You must be signed in to change notification settings - Fork 374
Support Nova Sonic #1013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Support Nova Sonic #1013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbrand
commented
Apr 21, 2025
packages/web/src/hooks/useSpeechToSpeech/AudioPlayerProcessor.worklet.js
Show resolved
Hide resolved
maekawataiki
approved these changes
May 7, 2025
Collaborator
maekawataiki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
For bidirectional communication, I'm currently using AppSync Event API. However, since limit exceeds errors occur frequently, I'm buffering more than necessary. I'm using AppSync Event API to maintain a serverless architecture, but if I determine it's difficult during the trial period, I may switch to a different implementation.
Let me explain the handshake flow. The client generates a channel ID and connects to that channel (via AppSync).
The server invokes a Lambda task with the channel ID as a parameter. Lambda then connects to AppSync accordingly, and after connecting, sends a notification that it's ready to AppSync. Once the client receives the ready notification, it begins transmitting audio.
Architecture Concerns
Checklist
npm run lintnpm run cdk:testand if there are snapshot differences, executenpm run cdk:test:update-snapshotto update snapshotsRelated Issues
#990