Skip to content

Add Vietnamese localization #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Vietnamese localization #1130

wants to merge 2 commits into from

Conversation

bach3
Copy link

@bach3 bach3 commented Jun 8, 2025

Description of Changes

I have added Vietnamese language support by adding the following files:

  • packages/web/public/locales/translation/vi.yaml
  • packages/web/public/locales/prompts/vi.yaml

Modified the following file:

  • packages\web\src\i18n\config.ts

Checklist

  • Modified relevant documentation
  • Verified operation in local environment
  • Executed npm run cdk:test and if there are snapshot differences, execute npm run cdk:test:update-snapshot to update snapshots

Related Issues

N/A

@kazuhitogo kazuhitogo self-assigned this Jun 9, 2025
@kazuhitogo
Copy link
Collaborator

Thank you for your Pull Request.
When I tested it in my environment, the Vietnamese language setting was not applied.
After investigating the cause, it seems to be due to the multi-line text notation in the yaml file not being properly reflected, and forgetting to enclose the symbol parts in double quotes. Since I was able to make it work with the following modifications, would it be possible for you to make these changes?
image
image

And, Did you forgot translate?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants