Skip to content

chore: address node.js security vulnerabilities #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

duartemendes
Copy link

@duartemendes duartemendes commented Apr 2, 2025

Issue #, if available: N.A.

Description of changes: Address security vulnerability CVE-2024-41818 from fast-xml-parser:

  1. fast-xml-parser is a dependency of @aws-sdk/client-cloudtrail
  2. Updating @aws-sdk/client-cloudtrail updates fast-xml-parser to v4.4.1, which no longer contains the vulnerability
  3. Latest @aws-sdk/client-cloudtrail requires node.js 18
  4. To use node.js 18 in the Amplify build, we need to update the Build image to amplify:al2023
  5. Updating the build image to amplify:al2023 requires changing how pipenv is installed and made available

In addition, Lambda will soon be deprecating Node.js 18 runtime. This PR upgrades Node.js runtime to v22.

These changes have been tested in a production environment.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@duartemendes
Copy link
Author

@tawoyinfa any blockers to merge this?

@dleicam
Copy link

dleicam commented May 13, 2025

Is the integration of this PR planned for the near future?

@duartemendes
Copy link
Author

I believe this was already somehow committed - 8c40957

@dleicam
Copy link

dleicam commented Jun 3, 2025

I believe this was already somehow committed - 8c40957

Or am I missing something, or the main branch doesn't have the Node update and is still using version 18. Right?

@duartemendes
Copy link
Author

It seems to have been reverted on this commit due to #367.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants