Update module reference including instances fetch - #451
Open
trinacriax wants to merge 2 commits into
Open
Conversation
trinacriax
changed the title
yprikhodko
reviewed
Aug 21, 2026
| FROM elasticache_reserved_cache_nodes_offerings | ||
| CROSS JOIN UNNEST(recurringcharges) AS t(charge) | ||
|
|
||
| KpiInstanceMappingView: |
Contributor
There was a problem hiding this comment.
I suggest not to release it as a part of CFN, but as a separate guidance under https://docs.aws.amazon.com/guidance/latest/cloud-intelligence-dashboards/data-collection-utilize-data.html.
Contributor
There was a problem hiding this comment.
Or we can have it deployed as a part of KPI dashboard
yprikhodko
reviewed
Aug 21, 2026
| rec['region'] = region | ||
| write(rec) | ||
|
|
||
| # Pull pricing data for instance types (pricing API is global, us-east-1 only) |
Contributor
There was a problem hiding this comment.
@trinacriax, https://github.com/aws-solutions-library-samples/cloud-intelligence-dashboards-data-collection/blob/main/data-collection/deploy/module-pricing.yaml module collects pricing data; could you please check if what is collected there is sufficient enough? I think it should be
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the
module-referenceLambda to collect instance pricing data from the AWS Pricing API (ElastiCache, RDS, OpenSearch) and adds an Athena view that computes instance generation, processor type, and upgrade paths for the KPI dashboard.Changes
Lambda enhancements:
pricing:GetProductsIAM permissionGlue tables: Add three new tables (
reference_pricing_elasticache_instances,reference_pricing_rds_instances,reference_pricing_opensearch_instances) for pricing data stored in S3Athena view (
kpi_instance_mapping): Cross-service view that resolves instance family, generation (Current/Previous), processor (Intel/AMD/Graviton), and upgrade paths using EC2 instance types as the authoritative processor sourceTests: Add integration tests for the three new pricing tables
Testing
test/test_from_scratch.pyvalidating data presence in each pricing table