[sdlf-cicd] extract create_repository into new file, add API-support gitlab #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlpzx
force-pushed
the
feat/API-integration-3p-git
branch
4 times, most recently
from
21a8543 to
d2eb1ad
Compare
dlpzx
force-pushed
the
feat/API-integration-3p-git
branch
from
d2eb1ad to
1ea4c74
Compare
jamieibbs
reviewed
Sep 4, 2025
docs/constructs/cicd.md
Outdated
|
|
||
| - `/SDLF/GitLab/Url` :: secure-string :: GitLab URL **with** trailing `/` | ||
| - `/SDLF/GitLab/AccessToken` :: secure-string :: User access token | ||
| - `/SDLF/GitLab/NamespaceId` :: string :: User/Enterprise namespace ID |
jamieibbs
reviewed
Sep 4, 2025
| - `/SDLF/GitLab/Url` :: secure-string :: GitLab URL **with** trailing `/` | ||
| - `/SDLF/GitLab/AccessToken` :: secure-string :: User access token | ||
| - `/SDLF/GitLab/NamespaceId` :: string :: User/Enterprise namespace ID | ||
| - `/SDLF/GitLab/CodeConnection` :: string :: CodeConnections ARN |
Contributor
Author
There was a problem hiding this comment.
You still need to connection to the codepipeline. I did not remove it to ensure the pipeline can read the gitlab repo as source (search for "{{resolve:ssm:/SDLF/${pGitPlatform}/CodeConnection}}" in the code)
dlpzx
force-pushed
the
feat/API-integration-3p-git
branch
from
7dfe0b5 to
e092b9c
Compare
kukushking
reviewed
Sep 8, 2025
| - !Sub "{{resolve:ssm:/SDLF/KMS/${pTeamName}/InfraKeyId:1}}" | ||
| - !Sub "{{resolve:ssm:/SDLF/KMS/${pTeamName}/DataKeyId:1}}" | ||
| - !Sub "{{resolve:ssm:/SDLF2/KMS/KeyArn:1}}" | ||
| - "{{resolve:ssm:/SDLF2/KMS/KeyArn:1}}" |
Contributor
Author
There was a problem hiding this comment.
Yes, there is nothing to replace using Sub, it should just resolve the SSM name. In the other 2 SSM params we are replacing pTeamName using Sub
kukushking
reviewed
Sep 8, 2025
| ssm = boto3.client("ssm", endpoint_url=ssm_endpoint_url) | ||
| codecommit_endpoint_url = "https://codecommit." + os.getenv("AWS_REGION") + ".amazonaws.com" | ||
| codecommit = boto3.client("codecommit", endpoint_url=codecommit_endpoint_url) | ||
| cloudformation_endpoint_url = "https://cloudformation." + os.getenv("AWS_REGION") + ".amazonaws.com" |
There was a problem hiding this comment.
nit - is this needed? wouldn't the default endpoint be the same?
Contributor
Author
There was a problem hiding this comment.
Using the same way of defining endpoints are before, you can check sdlf-cicd/lambda/domain-cicd/src/lambda_function.py
kukushking
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The CloudFormation resources for GitLab projects have some limitations and require hardcoded names for the namespaces/users.
Description of changes:
Refactored the lambda_function that creates the team repositories: moved creation logic outside of the lambda_handler file. Created a function for each git provider. In the GitLab provider, added API-first approach.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.