Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cars Deletion Feature #112

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

larsll
Copy link
Contributor

@larsll larsll commented Mar 16, 2025

Issue #:

Description of changes:
Feature covers:

  • Ability to delete cars from the Devices page.
  • Ability to filter on the last ping date (before / after date) on the Devices page.
  • Protections: Available to admin only. Only possible to delete offline cars.
  • Refactored Fleet Handling to use the DDB table for Cars as the master, which also includes that the Fleet Manager will call the Cars Manager via AppSync not Events. Benefit is that the UI will receive updates via AppSync subscriptions.

Additional comments:

  • The UI will only load online cars unless one specifically goes to the Offline page and click refresh. This is to reduce bandwidth / loading times in setups with a large number of devices.
  • The DDB entry of the car is deleted, this might impact the Fleets, as the Fleet<->Device assignments are stored in both tables.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@larsll larsll marked this pull request as ready for review March 17, 2025 07:43
@larsll larsll marked this pull request as draft March 17, 2025 07:55
@larsll larsll marked this pull request as ready for review March 18, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant