Fix EKS cluster version: pass to child modules, align to 1.32#57
Merged
sdpoueme merged 2 commits intoaws-solutions-library-samples:mainfrom Mar 31, 2026
Merged
Conversation
The root module's cluster_version variable was never passed to the child module blocks, so both clusters silently used the child module's own default of 1.28. Add cluster_version to both module calls, update the child default to 1.32, and align CloudFormation, buildspec kubectl, and README to match.
sdpoueme
approved these changes
Mar 31, 2026
Contributor
sdpoueme
left a comment
sdpoueme
left a comment
There was a problem hiding this comment.
Looks good. Safe and recommended best practices to upgrade the kubectl and eks versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56
Summary
cluster_version = var.cluster_versionto both module blocks interraform/cluster/main.tf. Previously the variable was never passed, so child modules silently used their own default (1.28).KubernetesVersionparameter default to "1.32".Files Changed
terraform/cluster/main.tfcluster_versionto both module blocksterraform/cluster/modules/cluster/variables.tfterraform/cloudformation/main.yamlterraform/cloudformation/buildspec.ymlREADME.mdTest plan
terraform validatepasses