feat: add manual quarantine option for sandbox accounts#86
Open
chrisns wants to merge 1 commit intoaws-solutions:mainfrom
Open
feat: add manual quarantine option for sandbox accounts#86chrisns wants to merge 1 commit intoaws-solutions:mainfrom
chrisns wants to merge 1 commit intoaws-solutions:mainfrom
Conversation
Add ability for administrators to manually quarantine accounts from the
accounts list page. This exposes the existing quarantineAccount business
logic via the API and UI.
- Add POST /accounts/{awsAccountId}/quarantine API endpoint
- Add quarantine resource to API Gateway infrastructure
- Add quarantineAccount method to frontend AccountService
- Add useQuarantineAccount hook with cache invalidation
- Add Quarantine option to Actions dropdown in ListAccounts
- Validate: block if status is Quarantine or CleanUp (409)
- Allow: Available, Active, Frozen statuses
Member
|
As always, thanks for the contribution @chrisns. Will discuss internally but I see this as a simple low effort improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides an example implementation for issue #85.
Summary
Adds a "Quarantine" option to the account Actions dropdown, allowing administrators to manually quarantine accounts when issues are detected (e.g., exhausted quotas, suspected compromise, incomplete cleanup).
Changes
POST /accounts/{awsAccountId}/quarantineendpoint with validation (blocks if alreadyQuarantineorCleanUp)quarantineAccount()methoduseQuarantineAccount()with cache invalidation for accounts and leasesImplementation Notes
This leverages the existing
InnovationSandbox.quarantineAccount()business logic, which handles lease termination and OU moves. No changes to core quarantine behaviour were required.Note to Maintainers
We understand that AWS Solutions' contribution policy means external code isn't merged directly. This PR is offered as a reference implementation to illustrate one possible approach, in case it's helpful as you consider the feature request.
Thank you for your consideration, and for maintaining this project.
Closes #85