fix(ci): limit e2e tests to cdk mainline#1500
Conversation
|
Claude Security Review: no high-confidence findings. (run) |
Package TarballHow to installgh release download pr-1500-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.18.0.tgz |
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
LGTM. Small, surgical change that does exactly what the description says — drops the cdk-source matrix dimension (cutting runners 12 → 6) and unconditionally runs the two steps that were previously gated on matrix.cdk-source == 'main' (Generate GitHub App Token, Build CDK package from main). Verified no stragglers reference matrix.cdk-source after the change, and the step display name is updated consistently.
The trade-off (no longer testing against the published npm CDK) is acknowledged in the description and the rationale (CDK ships before CLI, so the matrix arm provided limited signal) is sound. Easy to revert if 403s persist, and a workflow_dispatch override for an arbitrary CDK branch would be a clean way to bring back manual npm-source coverage if needed.
Problem
#1494
We receive intermittent 403s on control plane calls. The clients do not retry, since 403 is treated as non-retryable and the tests fail. Usually retrying fixes the issue.
Looking deeper, we don't see these request in CloudTrail, suggesting they are getting rejected before hitting the service at the edge. Given that we have both added significantly more tests recently, and run it across 12 runners, means we could be hammering those APIs, and get rate limited. The current evidence suggests this is the most likely cause.
Solution