Skip to content

fix(e2e): wire up payments env vars for full test suite#1505

Merged
aidandaly24 merged 3 commits into
aws:mainfrom
Hweinstock:fix/wire-up-payments-env-vars
Jun 10, 2026
Merged

fix(e2e): wire up payments env vars for full test suite#1505
aidandaly24 merged 3 commits into
aws:mainfrom
Hweinstock:fix/wire-up-payments-env-vars

Conversation

@Hweinstock

@Hweinstock Hweinstock commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Problem

Payments tests are silently skipped on full e2e test runs and may fail.
#1504

The permissions are also missing from the e2e test role and documentation.

Solution

  • wire up the necessary env vars to get payments to run. copying what was done here:
    # names the test reads. Absent on forks -> test self-skips via its hasCdpCreds gate.
    CDP_API_KEY_ID: ${{ env.E2E_CDP_API_KEY_ID }}
    CDP_API_KEY_SECRET: ${{ env.E2E_CDP_API_KEY_SECRET }}
    CDP_WALLET_SECRET: ${{ env.E2E_CDP_WALLET_SECRET }}
    .
  • add a clear logging message to make it clear when test is skipped.
  • update local testing script.
  • update ci role and documentation.

Testing

ran e2e tests locally.

More information can be found at: https://a.co/c895JFp
(Use `node --trace-warnings ...` to show where the warning was created)
[global-setup:stack-cleanup]:found 2 stacks
[global-setup:stack-cleanup]:deleting 2 stacks with names=AgentCore-E2eVercBedr99070720-default,AgentCore-E2eStraBedr98918939-default
[global-setup:stack-cleanup]:deleting stack with name AgentCore-E2eVercBedr99070720-default
[global-setup:stack-cleanup]:deleting stack with name AgentCore-E2eStraBedr98918939-default
[global-setup:stack-cleanup]:finished deleting stack in 15.072 seconds
[global-setup:stack-cleanup]:finished deleting stack in 37.354 seconds
[global-setup:stack-cleanup]:deleted 2 of 2 remaining stacks
[global-setup]:done cleaning up stacks after 37.667 seconds
[global-setup]:cleaning up stale credential providers...
[global-setup]:setup finished in 37.743 seconds
 ✓  e2e  e2e-tests/payment-strands-bedrock.test.ts > e2e: payments — create → add payment → deploy → status > has correct agentcore.json structure 2ms
 ✓  e2e  e2e-tests/payment-strands-bedrock.test.ts > e2e: payments — create → add payment → deploy → status > has payment capability code in agent 1ms
 ✓  e2e  e2e-tests/payment-strands-bedrock.test.ts > e2e: payments — create → add payment → deploy → status > deploys to AWS successfully 107518ms
 ✓  e2e  e2e-tests/payment-strands-bedrock.test.ts > e2e: payments — create → add payment → deploy → status > status shows payment manager 9655ms
 ✓  e2e  e2e-tests/payment-strands-bedrock.test.ts > e2e: payments — create → add payment → deploy → status > deployed-state.json has payment manager and connector info 1ms

 Test Files  1 passed (1)
      Tests  5 passed (5)
   Start at  16:50:15
   Duration  237.47s (transform 145ms, setup 0ms, import 1.24s, tests 196.37s, environment 0ms)

@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Jun 10, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Jun 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.19.0.tgz

How to install

gh release download pr-1505-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.19.0.tgz

@github-actions github-actions Bot added the size/s PR size: S label Jun 10, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Jun 10, 2026
@github-actions github-actions Bot added size/s PR size: S and removed size/s PR size: S labels Jun 10, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Jun 10, 2026
Comment thread e2e-tests/payment-strands-bedrock.test.ts
@Hweinstock Hweinstock marked this pull request as ready for review June 10, 2026 17:04
@Hweinstock Hweinstock requested a review from a team June 10, 2026 17:04

@aidandaly24 aidandaly24 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@aidandaly24 aidandaly24 merged commit ea2df09 into aws:main Jun 10, 2026
32 checks passed
@Hweinstock Hweinstock deleted the fix/wire-up-payments-env-vars branch June 10, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants