Skip to content

Fixes aws/amazon-chime-sdk-component-library-react#992 #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2025

Conversation

robhoff-laerdal
Copy link
Contributor

@robhoff-laerdal robhoff-laerdal commented May 6, 2025

Issue #: #992

Description of changes:

Adds node 22 as an allowed engine version.

Changes the node version used in the Build and Run Unit Tests job from 20.x to 22.x. This change will require updating the required checks for this repository to match the new check name Build and Run Unit Tests (22.x).

Testing

  1. Have you successfully run npm run build:release locally?

Yes, it ran successfully with the final output: OK: no uncommitted files.

  1. How did you test these changes?

I ran npm test while using node v22.14.0 and the results were equivalent to the results when using node v20.18.0. I looked at the node 21 and 22 release notes and did not see any breaking changes that would require any additional changes in this repository.

  1. If you made changes to the component library, have you provided corresponding documentation changes?

No changes were made to the component library.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Adds node 22 as an allowed engine version
@robhoff-laerdal robhoff-laerdal marked this pull request as ready for review May 6, 2025 13:36
@robhoff-laerdal robhoff-laerdal requested a review from a team as a code owner May 6, 2025 13:36
@robhoff-laerdal
Copy link
Contributor Author

robhoff-laerdal commented May 9, 2025

@xuesichao Is there anything I need to do to resolve the [Roster Integration Workflow / Roster Integration Test (pull_request)] check? It is not marked as required so it is ok to proceed with that failure?

@xuesichao
Copy link
Contributor

@xuesichao Is there anything I need to do to resolve the [Roster Integration Workflow / Roster Integration Test (pull_request)] check? It is not marked as required so it is ok to proceed with that failure?

Hi, the roster check has been somewhat unreliable, so we made it optional. However, there's an issue with the approval check - it's expecting Build and Run Unit Tests (20.x), but you've updated it to 22.x. We need to update the repository settings to look for Build and Run Unit Tests (22.x) instead. I don't have permission to change this setting, @ltrung could you help?
image

@ltrung ltrung merged commit 5c32deb into aws:main May 10, 2025
1 of 2 checks passed
@robhoff-laerdal robhoff-laerdal deleted the issue-992 branch May 12, 2025 12:32
@robhoff-laerdal
Copy link
Contributor Author

Thank you for the review and help @xuesichao. Do you know when the changes from this PR will be published/released?

@robhoff-laerdal
Copy link
Contributor Author

@ltrung Would you be able to provide any information on when the changes in this PR might be released for this package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants