Skip to content

Change console log to logger #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/providers/ContentShareProvider/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import React, {

import { ContentShareControlContextType } from '../../types';
import { useAudioVideo } from '../AudioVideoProvider';
import { useLogger } from '../LoggerProvider';
import {
ContentActionType,
ContentShareState,
Expand Down Expand Up @@ -41,6 +42,7 @@ export const ContentShareProvider: React.FC<
}>
> = ({ children, maxContentShares = 1 }) => {
const audioVideo = useAudioVideo();
const logger = useLogger();
const [state, dispatch] = useReducer(reducer, initialState);
const {
paused,
Expand All @@ -61,13 +63,13 @@ export const ContentShareProvider: React.FC<

useEffect(() => {
if (maxContentShares > MAX_SUPPORTED_CONTENT_SHARES) {
console.warn(
logger.warn(
`ContentShareProvider: maxContentShares value ${maxContentShares} exceeds the currently` +
` supported maximum of ${MAX_SUPPORTED_CONTENT_SHARES}.` +
`The value has been set to ${validatedMaxContentShares} instead.`
);
} else if (maxContentShares < MIN_SUPPORTED_CONTENT_SHARES) {
console.warn(
logger.warn(
`ContentShareProvider: maxContentShares value ${maxContentShares} is below the minimum` +
` of ${MIN_SUPPORTED_CONTENT_SHARES}. The value has been set to ${validatedMaxContentShares} instead.`
);
Expand Down
42 changes: 19 additions & 23 deletions src/providers/MeetingProvider/MeetingManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ export class MeetingManager implements AudioVideoObserver {
await this.meetingSession?.deviceController.chooseAudioOutput(null);
await this.meetingSession?.deviceController.destroy();
} catch (error) {
console.log(
this.logger.info(
'MeetingManager failed to clean up media resources on leave'
);
}
Expand All @@ -238,7 +238,7 @@ export class MeetingManager implements AudioVideoObserver {
}

audioVideoDidStart = (): void => {
console.log(
this.logger.info(
'[MeetingManager audioVideoDidStart] Meeting started successfully'
);
this.meetingStatus = MeetingStatus.Succeeded;
Expand All @@ -259,37 +259,37 @@ export class MeetingManager implements AudioVideoObserver {
const sessionStatusCode = sessionStatus.statusCode();
switch (sessionStatusCode) {
case MeetingSessionStatusCode.MeetingEnded:
console.log(
this.logger.info(
`[MeetingManager audioVideoDidStop] Meeting ended for all: ${sessionStatusCode}`
);
this.meetingStatus = MeetingStatus.Ended;
break;
case MeetingSessionStatusCode.Left:
console.log(
this.logger.info(
`[MeetingManager audioVideoDidStop] Left the meeting: ${sessionStatusCode}`
);
this.meetingStatus = MeetingStatus.Left;
break;
case MeetingSessionStatusCode.AudioJoinedFromAnotherDevice:
console.log(
this.logger.info(
`[MeetingManager audioVideoDidStop] Meeting joined from another device: ${sessionStatusCode}`
);
this.meetingStatus = MeetingStatus.JoinedFromAnotherDevice;
break;
default:
// The following status codes are Failures according to MeetingSessionStatus
if (sessionStatus.isFailure() && !sessionStatus.isTerminal()) {
console.log(
this.logger.info(
`[MeetingManager audioVideoDidStop] Non-Terminal failure occurred: ${sessionStatusCode}`
);
this.meetingStatus = MeetingStatus.Failed;
} else if (sessionStatus.isTerminal()) {
console.log(
this.logger.info(
`[MeetingManager audioVideoDidStop] Terminal failure occurred: ${sessionStatusCode}`
);
this.meetingStatus = MeetingStatus.TerminalFailure;
} else {
console.log(
this.logger.info(
`[MeetingManager audioVideoDidStop] session stopped with code ${sessionStatusCode}`
);
}
Expand Down Expand Up @@ -372,7 +372,7 @@ export class MeetingManager implements AudioVideoObserver {
this.publishDeviceLabelTriggerStatus();
return stream;
} catch (error) {
console.error('MeetingManager failed to get device permissions');
this.logger.error('MeetingManager failed to get device permissions');
this.deviceLabelTriggerStatus = DeviceLabelTriggerStatus.DENIED;
this.publishDeviceLabelTriggerStatus();
throw error;
Expand Down Expand Up @@ -440,9 +440,8 @@ export class MeetingManager implements AudioVideoObserver {
this.audioInputDevices[0].deviceId
);
} catch (error) {
console.error(
'MeetingManager failed to select audio input device on join',
error
this.logger.error(
`MeetingManager failed to select audio input device on join: ${error}`
);
}
this.publishSelectedAudioInputDevice();
Expand All @@ -460,9 +459,8 @@ export class MeetingManager implements AudioVideoObserver {
this.audioOutputDevices[0].deviceId
);
} catch (error) {
console.error(
'MeetingManager failed to select audio output device on join',
error
this.logger.error(
`MeetingManager failed to select audio output device on join: ${error}`
);
}
}
Expand Down Expand Up @@ -492,7 +490,7 @@ export class MeetingManager implements AudioVideoObserver {
newError.name = error.name;
newError.message += ' ' + error.message;
}
console.error(newError);
this.logger.error(newError.toString());
throw newError;
}
};
Expand All @@ -503,9 +501,8 @@ export class MeetingManager implements AudioVideoObserver {
this.selectedAudioOutputDevice = deviceId;
this.publishSelectedAudioOutputDevice();
} catch (error) {
console.error(
'MeetingManager failed to select audio output device',
error
this.logger.error(
`MeetingManager failed to select audio output device: ${error}`
);
throw new Error('MeetingManager failed to select audio output device');
}
Expand All @@ -524,7 +521,7 @@ export class MeetingManager implements AudioVideoObserver {
newError.name = error.name;
newError.message += ' ' + error.message;
}
console.error(newError);
this.logger.error(newError.toString());
throw newError;
}
};
Expand All @@ -535,9 +532,8 @@ export class MeetingManager implements AudioVideoObserver {
this.selectedVideoInputDevice = undefined;
this.publishSelectedVideoInputDevice();
} catch (error) {
console.error(
'MeetingManager failed to unselect video input device',
error
this.logger.error(
`MeetingManager failed to unselect video input device: ${error}`
);
throw new Error('MeetingManager failed to unselect video input device');
}
Expand Down
Loading