Skip to content

Conversation

@JonathanWbn
Copy link

@JonathanWbn JonathanWbn commented May 30, 2025

This PR adds React 19 compatibility while maintaining backward compatibility with React 17 and 18. Solves #991

Changes Made

  • Updated react and react-dom (and their type-packages) to support v19
  • Fixed JSX.Element type issues by migrating to React.ReactNode and React.JSX.Element
  • Updated hook signatures to handle stricter null types in React 19
  • Fixed useRef() calls to provide proper initial values
  • Replaced deprecated Simulate from react-dom/test-utils with fireEvent
  • Updated Storybook to v8 (for React 19 support)
  • Updated Jest configuration for Storybook v8 compatibility
  • Updated @testing-library/react to v16.3.0 and @testing-library/dom to v10.4.0 for React 19 compatibility
  • Fixed transform-origin DOM property warnings in SVG components by using proper React syntax

@JonathanWbn JonathanWbn marked this pull request as ready for review May 30, 2025 10:02
@JonathanWbn JonathanWbn requested a review from a team as a code owner May 30, 2025 10:02
JonathanWbn and others added 2 commits June 2, 2025 23:02
- Update @testing-library/react to 16.3.0 and @testing-library/dom to 10.4.0
- Fix transform-origin DOM property warnings in SVG components
@Punie
Copy link

Punie commented Oct 2, 2025

Will this be merged someday?

@ltrung
Copy link
Contributor

ltrung commented Oct 16, 2025

Will this be merged someday?

@Punie , We will prioritize to review and merge this soon.

@JonathanWbn
Copy link
Author

Obsolete with #1008

@ziyiz-amzn
Copy link
Contributor

@JonathanWbn Thank you for raising the initial PR. I've completed and merged #1008, building upon your work.

Please track the libraries release schedule here - aws/amazon-chime-sdk-js#3114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants