Add integ test for windows event id filtering - #541
Merged
Conversation
okankoAMZ
reviewed
Jun 20, 2025
Contributor
|
In your description, please describe what aspects you are trying to test |
sky333999
reviewed
Jun 20, 2025
Paamicky
force-pushed
the
WindowsEventIDTest
branch
from
June 22, 2025 23:31
fed1af8 to
ded3998
Compare
dricross
reviewed
Jun 23, 2025
Paamicky
force-pushed
the
WindowsEventIDTest
branch
4 times, most recently
from
June 25, 2025 17:34
1bdbab1 to
465436b
Compare
dricross
reviewed
Jun 25, 2025
okankoAMZ
reviewed
Jun 25, 2025
Paamicky
force-pushed
the
WindowsEventIDTest
branch
2 times, most recently
from
June 27, 2025 18:21
f72152a to
8f726a5
Compare
okankoAMZ
previously approved these changes
Jun 27, 2025
dricross
previously approved these changes
Jun 27, 2025
dricross
left a comment
dricross
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Let's merge together with the agent changes though, so please hold off until the agent PR is also approved.
Paamicky
force-pushed
the
WindowsEventIDTest
branch
from
July 9, 2025 15:20
8559ae6 to
eaa2256
Compare
Paamicky
changed the title
Paamicky
force-pushed
the
WindowsEventIDTest
branch
from
July 18, 2025 20:04
eaa2256 to
2686361
Compare
dricross
approved these changes
Jul 21, 2025
okankoAMZ
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
Testing that the Event ID filtering logic works as expected
Description of changes
Add eventId test case to validate eventId filtering to CloudWatch
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Integration test showing event id test case passed
Integration test