Skip to content

Zero-allocation optimization for sendLine and readLine #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duhminick merged 7 commits into from
Aug 4, 2025
Merged

Zero-allocation optimization for sendLine and readLine #1803

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dc8dfbf
Zero-allocation optimization for sendLine and readLine
duhminick Jul 28, 2025
ff2152f
Zero out Line object before putting back into pool
duhminick Aug 1, 2025
dc06313
Merge branch 'main' into dominic-zero-allocation
duhminick Aug 1, 2025
ecc9fae
644 to 600 - not sure how this popped up again
duhminick Aug 1, 2025
03b0e7c
Move back ReleaseLine
duhminick Aug 1, 2025
efd80d9
Remove unsafe.String
duhminick Aug 1, 2025
2f89d6a
Follow pattern for writing file in test
duhminick Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions plugins/inputs/logfile/tail/tail.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,6 +641,7 @@ func (tail *Tail) unreadByte() (err error) {
}

func (tail *Tail) ReleaseLine(line *Line) {
*line = Line{}

@duhminick duhminick Aug 1, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL: this won't go to the heap because the compiler is smart enough to not "escape" it

tail.linePool.Put(line)
Comment thread
duhminick marked this conversation as resolved.
}

Expand Down
9 changes: 6 additions & 3 deletions plugins/inputs/logfile/tail/tail_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,10 +341,13 @@ func TestLinePooling(t *testing.T) {
tail.ReleaseLine(line)
}

// Verify pool reuse by checking if we get an object with one of the lines
// Line object should be zeroed out because we released it
pooledLine := tail.linePool.Get().(*Line)
assert.Contains(t, []string{"line1", "line2", "line3"}, pooledLine.Text)
tail.linePool.Put(pooledLine)
assert.Empty(t, pooledLine.Text, "Pooled line should remain zeroed")
assert.Empty(t, pooledLine.Time, "Pooled line should remain zeroed")
assert.Empty(t, pooledLine.Err, "Pooled line should remain zeroed")
assert.Empty(t, pooledLine.Offset, "Pooled line should remain zeroed")
tail.ReleaseLine(pooledLine)
}

// TestConcurrentLinePoolAccess tests that the line pool is thread-safe
Expand Down
Loading