Revert "Bump Go (#1845)" - #1851
Merged
Merged
Conversation
This reverts commit ed3141e.
dricross
marked this pull request as ready for review
September 5, 2025 18:35
TravisStark
approved these changes
Sep 5, 2025
duhminick
approved these changes
Sep 5, 2025
movence
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit ed3141e.
Description of the issue
The Go bump PR didn't actually test anything because it pulled from the github cache and we're now running into issues. The linter we use is incomaptible with go1.25 and unit tests are regularly failing on windows-2022: https://github.com/aws/amazon-cloudwatch-agent/actions/runs/17499483424/job/49712282164?pr=1849
Description of changes
Reverting the commit. We will re-do the Go bump.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Describe what tests you have done.
Requirements
Before commiting your code, please do the following steps.
make fmtandmake fmt-shmake lintIntegration Tests
To run integration tests against this PR, add the
ready for testinglabel.