Skip to content

[Fix] Added node_(gpu|efa|neuroncore)_request metric #1859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aadam19 wants to merge 1 commit into from
Closed

[Fix] Added node_(gpu|efa|neuroncore)_request metric #1859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions translator/tocwconfig/sampleConfig/emf_and_kubernetes_with_gpu_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,16 +190,19 @@ exporters:
- node_status_condition_unknown
- node_status_capacity_pods
- node_status_allocatable_pods
- node_gpu_request

@sky333999 sky333999 Sep 12, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure we want this? I think this was left out in the past since request & limit are always the same for GPUs.

- node_gpu_limit
- node_gpu_usage_total
- node_gpu_reserved_capacity
- node_gpu_unreserved_capacity
- node_gpu_available_capacity
- node_neuroncore_request
- node_neuroncore_limit
- node_neuroncore_usage_total
- node_neuroncore_reserved_capacity
- node_neuroncore_unreserved_capacity
- node_neuroncore_available_capacity
- node_efa_request
- node_efa_limit
- node_efa_usage_total
- node_efa_reserved_capacity
Expand Down
6 changes: 3 additions & 3 deletions translator/translate/otel/exporter/awsemf/kubernetes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,9 +156,9 @@ func getNodeMetricDeclarations(conf *confmap.Conf) []*awsemfexporter.MetricDecla
"node_status_capacity_pods", "node_status_allocatable_pods",
}
if awscontainerinsight.AcceleratedComputeMetricsEnabled(conf) {
nodeMetrics = append(nodeMetrics, "node_gpu_limit", "node_gpu_usage_total", "node_gpu_reserved_capacity", "node_gpu_unreserved_capacity", "node_gpu_available_capacity")
nodeMetrics = append(nodeMetrics, "node_neuroncore_limit", "node_neuroncore_usage_total", "node_neuroncore_reserved_capacity", "node_neuroncore_unreserved_capacity", "node_neuroncore_available_capacity")
nodeMetrics = append(nodeMetrics, "node_efa_limit", "node_efa_usage_total", "node_efa_reserved_capacity", "node_efa_unreserved_capacity", "node_efa_available_capacity")
nodeMetrics = append(nodeMetrics, "node_gpu_request", "node_gpu_limit", "node_gpu_usage_total", "node_gpu_reserved_capacity", "node_gpu_unreserved_capacity", "node_gpu_available_capacity")
nodeMetrics = append(nodeMetrics, "node_neuroncore_request", "node_neuroncore_limit", "node_neuroncore_usage_total", "node_neuroncore_reserved_capacity", "node_neuroncore_unreserved_capacity", "node_neuroncore_available_capacity")
nodeMetrics = append(nodeMetrics, "node_efa_request", "node_efa_limit", "node_efa_usage_total", "node_efa_reserved_capacity", "node_efa_unreserved_capacity", "node_efa_available_capacity")
}
if enhancedContainerInsightsEnabled {
return []*awsemfexporter.MetricDeclaration{
Expand Down
Loading