Fixing windows build flakiness #1931
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paramadon
added
the
ready for testing
Paramadon
changed the title
jefchien
reviewed
Nov 3, 2025
| tail.Killf("Error watching for changes on %s: %s", tail.Filename, err) | ||
| return | ||
| // Only set up file watchers if we're following the file | ||
| if tail.Follow { |
There was a problem hiding this comment.
Follow is always set to true. https://github.com/aws/amazon-cloudwatch-agent/blob/main/plugins/inputs/logfile/logfile.go#L222
Paramadon
force-pushed
the
paramadon/windowsBuildFix
branch
from
944d6c4 to
684921b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Fixing flaky windows build failures. Currently the windows build is flaky and is causing merging delays as tests needs to be rerun after failure repeatedly until they work - here's an example of a pr with 4 windows test failures where each run takes 20-25+ min... - https://github.com/aws/amazon-cloudwatch-agent/actions/runs/18954707387/job/54203959187?pr=1930.
It seems like the issue is that we are setting up watcher when follow (follow true just means basically like tail -f vs false is like a cat) is false which should not happen and the watch is deadlocking.
Description of changes
Make sure to only set up watcher if tail.Follow is true.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Describe what tests you have done.