Fix auto_removal deleting wrong file during log rotation #1966
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When log rotation occurs (e.g., via lumberjack), the
auto_removalfeature was deleting the new log file instead of the rotated one. This caused:Root Cause
cleanUp()usedts.tailer.Filename(a string) to remove the file. After rotation:app.log→app.log.1and creates newapp.logos.Remove("app.log")Solution
Track the file by inode instead of filename:
app.log.1)Testing
Added
TestAutoRemovalWithLogRotationthat:Test passes with the fix, fails without it.
Compatibility
TestLogsFileAutoRemovalstill passes