Format JVM metrics units for Tomcat - #2235
Open
Paamicky wants to merge 3 commits into
Open
Conversation
Paamicky
marked this pull request as ready for review
August 6, 2026 14:23
Contributor
Binary Size Reportlinux/amd64
linux/arm64
windows/amd64
Investigating size changesUse go-size-analyzer to compare binaries: GOEXPERIMENT=jsonv2 go install github.com/Zxilly/go-size-analyzer/cmd/gsa@latest
gsa diff --old <baseline-binary> --new <new-binary> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
Since CWA v1.300061.0, the bundled JMX Metric Gatherer JAR switched Tomcat/JVM metric units to UCUM annotation format ({session}, {thread}, {class}, {collection}, {request}, {error}). The agent's
knownNonConvertibleUnitsset only contains old-format strings, causingnon-convertibleunit warning logs every collection interval. No data loss occurs (metrics still publish with unit None), but the log noise degrades readability for customers running Tomcat/JVM monitoring.Issue: https://issues.amazon.com/issues/CWQS-3574
Description of changes
internal/cloudwatch/unit.go. This suppresses the spurious warning logs without changing metric publishing behavior.License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Requirements
Integration Tests
To run integration tests against this PR, add the ready for testing label.