Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mcp enablement squashed #883

Merged
merged 18 commits into from
Mar 21, 2025
Merged

Mcp enablement squashed #883

merged 18 commits into from
Mar 21, 2025

Conversation

dingfeli
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dingfeli dingfeli requested a review from a team as a code owner March 21, 2025 16:36
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 37.03704% with 663 lines in your changes missing coverage. Please review.

Project coverage is 13.86%. Comparing base (44b8205) to head (0f1ae52).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
crates/mcp_client/test_mcp_server/test_server.rs 0.00% 178 Missing ⚠️
crates/mcp_client/src/server.rs 0.00% 175 Missing ⚠️
crates/q_cli/src/cli/chat/tool_manager.rs 19.78% 64 Missing and 9 partials ⚠️
crates/q_cli/src/cli/chat/tools/custom_tool.rs 0.00% 68 Missing ⚠️
crates/mcp_client/src/transport/stdio.rs 44.33% 54 Missing and 5 partials ⚠️
crates/mcp_client/src/client.rs 84.82% 33 Missing and 18 partials ⚠️
crates/mcp_client/src/error.rs 0.00% 18 Missing ⚠️
crates/mcp_client/src/transport/base_protocol.rs 36.00% 16 Missing ⚠️
crates/mcp_client/src/lib.rs 53.33% 4 Missing and 3 partials ⚠️
crates/mcp_client/src/transport/mod.rs 0.00% 6 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #883      +/-   ##
==========================================
+ Coverage   13.74%   13.86%   +0.11%     
==========================================
  Files        2360     2370      +10     
  Lines      204440   205527    +1087     
  Branches   184804   185891    +1087     
==========================================
+ Hits        28109    28498     +389     
- Misses     174840   175506     +666     
- Partials     1491     1523      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dingfeli dingfeli merged commit 853d86b into main Mar 21, 2025
20 checks passed
@dingfeli dingfeli deleted the mcp-enablement-squashed branch March 21, 2025 20:58
@dingfeli dingfeli restored the mcp-enablement-squashed branch March 21, 2025 20:58
jsamuel1 pushed a commit to jsamuel1/amazon-q-developer-cli that referenced this pull request Mar 22, 2025
* Squashed mcp-enablement changes

* moves shellexpand to workspace dep

* reverts changes in lock file

* fixes tests

* fixes fmt

* updates lock file

* Revert "updates lock file"

This reverts commit f847c6f.

* uses lock file from main

* updates lock file

* regenerates lock file

* updates ci workflow to do a full fetch

* allows lock file to be generated offline in the ci

* Revert "allows lock file to be generated offline in the ci"

This reverts commit 40a3b1a.

* allows all custom tool actions

* disables cache to get through CI

* Revert "disables cache to get through CI"

This reverts commit 46277c8.

* force regenerate lock file

* force regenerate lock file for test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants